Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP io] Limit information exposed though contact methods #134

Merged
merged 3 commits into from
Jan 25, 2020

Conversation

sergiitk
Copy link
Owner

What's this PR do?

  • Contact Methods minor refactoring

@sergiitk sergiitk changed the title [CHORE io] Limit information exposed though contact methods [CLEANUP io] Limit information exposed though contact methods Jan 25, 2020
@codecov
Copy link

codecov bot commented Jan 25, 2020

Codecov Report

Merging #134 into master will increase coverage by 0.42%.
The diff coverage is 23.07%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #134      +/-   ##
========================================
+ Coverage    7.27%   7.7%   +0.42%     
========================================
  Files          22     23       +1     
  Lines         522    532      +10     
========================================
+ Hits           38     41       +3     
- Misses        484    491       +7
Impacted Files Coverage Δ
src/pagerbeauty.js 0% <ø> (ø) ⬆️
src/models/OnCall.js 44.44% <0%> (-1.71%) ⬇️
src/services/OnCallsService.js 0% <0%> (ø) ⬆️
src/app/PagerBeautyWorker.js 0% <0%> (ø) ⬆️
src/models/ContactMethod.js 42.85% <42.85%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c51186...090c7d2. Read the comment docs.

@sergiitk sergiitk merged commit 2fc19c2 into master Jan 25, 2020
@sergiitk sergiitk deleted the chore/minor-fixes-to-contact-info branch January 25, 2020 00:40
sergiitk pushed a commit that referenced this pull request Jan 25, 2020
# [1.1.0](v1.0.3...v1.1.0) (2020-01-25)

### Cleanup

- [134](#134) **io** Limit information exposed though contact methods

### Features

- [126](#126) **ui** Added optional user contact information to the schedule view
@sergiitk
Copy link
Owner Author

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant