Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX ui-oncalls] Handle one user in the rotation (no end date) #80

Merged
merged 3 commits into from
Jan 22, 2019

Conversation

sergiitk
Copy link
Owner

@sergiitk sergiitk commented Jan 22, 2019

What's this PR do?

  • Add schedule PJ1P5JQ to acceptance tests
  • Handle one user in the rotation: previously displayed "To: Invalid Date, Invalid Date".

image

@codecov
Copy link

codecov bot commented Jan 22, 2019

Codecov Report

Merging #80 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #80   +/-   ##
======================================
  Coverage    7.21%   7.21%           
======================================
  Files          19      19           
  Lines         485     485           
  Branches       77      77           
======================================
  Hits           35      35           
  Misses        447     447           
  Partials        3       3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaebc02...5acdd4c. Read the comment docs.

@sergiitk sergiitk changed the title [BUGFIX core-oncalls] Handle one user in rotation (no end date) [BUGFIX core-oncalls] Handle one user in the rotation (no end date) Jan 22, 2019
@sergiitk sergiitk changed the title [BUGFIX core-oncalls] Handle one user in the rotation (no end date) [BUGFIX ui-oncalls] Handle one user in the rotation (no end date) Jan 22, 2019
@sergiitk sergiitk merged commit 7ee14e5 into master Jan 22, 2019
@sergiitk sergiitk deleted the bugfix/invalid-date branch January 22, 2019 03:59
sergiitk pushed a commit that referenced this pull request Feb 7, 2019
# [1.0.0](v0.3.0...v1.0.0) (2019-02-07)

### Bug Fixes

- [79](#79) **core** Fix error handling on unknown schedules
- [80](#80) **ui-oncalls** Handle one user in the rotation (no end date)

### Cleanup

- [75](#75) **chore-dependencies** Dependencies upgrade
- [64](#64) **chore-dependencies** Dependencies upgrade
- [83](#83) **chore-dependencies** Dependencies upgrade
- [87](#87) **circleci** Move test key from secrets to allow exogenous PRs
- [70](#70) **core** Load Schedules separately from OnCalls
- [69](#69) **core** Move schedule loading out of web controller
- [65](#65) **misc-local-dev** Acceptance tests in Docker
- [62](#62) **misc-release** Automated Docker image builds with basic sanity checks
- [71](#71) **misc-release** Improve Semantic Release
- [66](#66) **misc-release** Run acceptance tests in CircleCI
- [68](#68) **tests** Better test reports
- [67](#67) **tests** Setup unit test tools and refactor acceptance tests

### Documentation

- [78](#78) **deploy** Document deploying PagerBeauty to Heroku
- [90](#90) **readme** Add PagerBeauty on Grafana Dashboard screenshot
- [86](#86) **readme** Fix minor typo
- [89](#89) **readme** Update Adding to Datadog dashboard gif
- [85](#85) **readme** Update caps on Datadog

### Features

- [73](#73) **core-incidents** Poll for active incidents
- [72](#72) **core-oncalls** Removes implicit limit on how many on-calls can be loaded
- [77](#77) **core-web** HTTP server can be started on custom port
- [82](#82) **core-web** Support for Authentication Bearer access_token
- [88](#88) **grafana** Support Grafana
- [74](#74) **ui-oncalls** On-call active incident view: show incident info and make red
@sergiitk
Copy link
Owner Author

sergiitk commented Feb 7, 2019

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sergiitk sergiitk mentioned this pull request Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant