feat: sslnegotiation and direct ssl for postgres 17 #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfackler
reviewed
Jul 6, 2024
sfackler
reviewed
Jul 6, 2024
| @@ -25,18 +26,20 @@ where | |||
| SslMode::Prefer | SslMode::Require => {} | |||
There was a problem hiding this comment.
Should there be any special behavior for sslmode=prefer sslnegotiation=direct?
There was a problem hiding this comment.
No. When sslmode is prefer or required, we go directly to ssl handshake just like other ssl based protocol, for example, https. And those TLS libraries will initialize the handshake process, we don't need to do anything here.
sfackler
reviewed
Jul 6, 2024
sfackler
reviewed
Jul 6, 2024
|
Seems reasonable to me, but I think it might make sense to wait on merging until 17 releases. |
|
No problem. I'm using this to test my own postgresql wire protocol implementation And the clippy issue seems not related to this patch, I can create another one to fix that. Edit: Just saw it's been fixed on default branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds Direct SSL support which is a new feature coming in PostgreSQL 17. With this option, we issue TLS handshake directly without
SslRequest. This will save a roundtrip on connection opening.I just follow how libpq is designed, to offer an option
sslnegotiationto control this behaviour (because it won't work on Postgres 16 or earlier).