Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev version of tabyl fails to suppress NA when show_na = FALSE #127

Closed
sfirke opened this issue Jul 18, 2017 · 0 comments
Closed

dev version of tabyl fails to suppress NA when show_na = FALSE #127

sfirke opened this issue Jul 18, 2017 · 0 comments

Comments

@sfirke
Copy link
Owner

sfirke commented Jul 18, 2017 

> y <- mtcars
> y$carb[1] <- NA
> y %>% tabyl(carb)
  carb  n percent valid_percent
1    1  7 0.21875    0.22580645
2    2 10 0.31250    0.32258065
3    3  3 0.09375    0.09677419
4    4  9 0.28125    0.29032258
5    6  1 0.03125    0.03225806
6    8  1 0.03125    0.03225806
7   NA  1 0.03125            NA
> y %>% tabyl(carb, show_na = FALSE)
  carb  n percent valid_percent
1    1  7 0.21875    0.22580645
2    2 10 0.31250    0.32258065
3    3  3 0.09375    0.09677419
4    4  9 0.28125    0.29032258
5    6  1 0.03125    0.03225806
6    8  1 0.03125    0.03225806
7   NA  1 0.03125            NA
sfirke added a commit that referenced this issue Jul 18, 2017
@sfirke
add failing test for #127
301c30b 
having problems with my computer so editing the file directly on GitHub :face-with-rolling-eyes:
sfirke added a commit that referenced this issue Jul 18, 2017
@sfirke
add failing test for #127 - tabyl(... show_na = FALSE) fails
09c67a1
@sfirke sfirke closed this as completed in e20dbef Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sfirke