Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control allowing of duplicate names with allow_dupes #519

Merged
merged 2 commits into from
Jan 29, 2023

Conversation

sfirke
Copy link
Owner

@sfirke sfirke commented Jan 29, 2023

Implements #495 using initial version of #497 to address issues identified and solution proposed in #513

@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Merging #519 (c6bce7e) into main (31a9dd2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #519   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines         1130      1141   +11     
=========================================
+ Hits          1130      1141   +11     
Impacted Files Coverage Δ
R/make_clean_names.R 100.00% <100.00%> (ø)

@billdenney
Copy link
Collaborator

Looks good to me. Merged.

@billdenney billdenney merged commit 7ef76d3 into main Jan 29, 2023
@billdenney billdenney deleted the revert_deduplication branch January 29, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants