Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPTCP support #1156

Closed
skeggse opened this issue Mar 23, 2023 · 5 comments
Closed

MPTCP support #1156

skeggse opened this issue Mar 23, 2023 · 5 comments

Comments

@skeggse
Copy link

skeggse commented Mar 23, 2023

It looks like shadowsocks-libev supports a --mptcp flag on supported Kernels, and it'd be neat to have feature parity with that flag in shadowsocks-rust!
@skeggse skeggse mentioned this issue Mar 23, 2023
Merged
@zonyitoo
Copy link
Collaborator

Well, I didn’t realize that it was actually useful.

zonyitoo added a commit that referenced this issue Mar 24, 2023
@zonyitoo
feat(mptcp): Basic implementation of Multipath-TCP
cd327da 
  - Currently support macOS (Client Only) and Linux (> 5.19)
  - ref #1156
@zonyitoo zonyitoo mentioned this issue Mar 24, 2023
Merged
zonyitoo added a commit that referenced this issue Mar 24, 2023
@zonyitoo
feat(mptcp): Basic implementation of Multipath-TCP
a502fd4 
  - Currently support macOS (Client Only) and Linux (> 5.19)
  - ref #1156
zonyitoo added a commit that referenced this issue Mar 24, 2023
@zonyitoo
feat(mptcp): Basic implementation of Multipath-TCP
d5ac1d5 
  - Currently support macOS (Client Only) and Linux (> 5.19)
  - ref #1156
zonyitoo added a commit that referenced this issue Mar 24, 2023
@zonyitoo
feat(mptcp): Basic implementation of Multipath-TCP
c7989a2 
  - Currently support macOS (Client Only) and Linux (> 5.19)
  - ref #1156
zonyitoo added a commit that referenced this issue Mar 25, 2023
@zonyitoo
feat(mptcp): Basic implementation of Multipath-TCP
fabe2d9 
  - Currently support macOS (Client Only) and Linux (> 5.19)
  - ref #1156
zonyitoo added a commit that referenced this issue Mar 26, 2023
@zonyitoo
feat(mptcp): Basic implementation of Multipath-TCP
28d5104 
  - Currently support macOS (Client Only) and Linux (> 5.19)
  - ref #1156
zonyitoo added a commit that referenced this issue Mar 26, 2023
@zonyitoo
feat(mptcp): Basic implementation of Multipath-TCP
4663d53 
  - Currently support macOS (Client Only) and Linux (> 5.19)
  - ref #1156
zonyitoo added a commit that referenced this issue Mar 26, 2023
@zonyitoo
feat(mptcp): Basic implementation of Multipath-TCP
3bd1b52 
  - Currently support macOS (Client Only) and Linux (> 5.19)
  - ref #1156
zonyitoo added a commit that referenced this issue Mar 26, 2023
@zonyitoo
feat(mptcp): Basic implementation of Multipath-TCP
b06a871 
  - Currently support macOS (Client Only) and Linux (> 5.19)
  - ref #1156
zonyitoo added a commit that referenced this issue Mar 26, 2023
@zonyitoo
feat(mptcp): Basic implementation of Multipath-TCP
e2b27cf 
  - Currently support macOS (Client Only) and Linux (> 5.19)
  - ref #1156
zonyitoo added a commit that referenced this issue Apr 4, 2023
@zonyitoo
feat(mptcp): Basic implementation of Multipath-TCP
0678d81 
  - Currently support macOS (Client Only) and Linux (> 5.19)
  - ref #1156
zonyitoo added a commit that referenced this issue Apr 4, 2023
@zonyitoo
feat(mptcp): Basic implementation of Multipath-TCP
fdbf15a 
  - Currently support macOS (Client Only) and Linux (> 5.19)
  - ref #1156
zonyitoo added a commit that referenced this issue Apr 5, 2023
@zonyitoo
feat(mptcp): Basic implementation of Multipath-TCP
7d7fb19 
  - Currently support macOS (Client Only) and Linux (> 5.19)
  - ref #1156
@xinlake
Copy link

xinlake commented Apr 12, 2023

  • Windows 11
  • stable-x86_64-pc-windows-msvc unchanged - rustc 1.68.2 (9eb3afe9e 2023-03-27)

v1.15.2 compiles successfully and works fine, v1.15.3 compiles with errors

   Compiling clap v4.2.1
   Compiling xdg v2.4.1
   Compiling daemonize v0.5.0
   Compiling sysexits v0.5.0
   Compiling trust-dns-resolver v0.22.0
   Compiling shadowsocks v1.15.3 (E:\OSS\SourceCode\Client-Android-Optimize\core\src\main\rust\shadowsocks-rust\crates\shadowsocks)
error[E0425]: cannot find value `IPPROTO_MPTCP` in crate `libc`
   --> crates\shadowsocks\src\net\sys\unix\linux\mod.rs:224:64
    |
224 |         let fd = libc::socket(family, libc::SOCK_STREAM, libc::IPPROTO_MPTCP);
    |                                                                ^^^^^^^^^^^^^ help: a constant with a similar name exists: `IPPROTO_MTP`
    |
   ::: D:\Rust\.cargo\registry\src\github.com-1ecc6299db9ec823\libc-0.2.141\src\unix\linux_like\mod.rs:885:1
    |
885 | pub const IPPROTO_MTP: ::c_int = 92;
    | ------------------------------ similarly named constant `IPPROTO_MTP` defined here

For more information about this error, try `rustc --explain E0425`.
error: could not compile `shadowsocks` due to previous error
warning: build failed, waiting for other jobs to finish...

@zonyitoo
Copy link
Collaborator

Why your rustc with windows target compiled the code only for Linux?

@xinlake
Copy link

xinlake commented Apr 13, 2023

Why your rustc with windows target compiled the code only for Linux?

I'm compiling Shadowsocks Rust for Android app on Windows PC.

  • Rust Toolchain: stable-x86_64-pc-windows-msvc
  • Rust Target: aarch64-linux-android, armv7-linux-androideabi

@zonyitoo zonyitoo mentioned this issue Apr 13, 2023
Merged
zonyitoo added a commit that referenced this issue Apr 15, 2023
@zonyitoo
feat(mptcp): MPTCP on Linux try to set keepalive time & interval
c1f505f 
- TCP_KEEPIDLE, TCP_KEEPINTV may be supported in the future kernel
- multipath-tcp/mptcp_net-next#383
- ref #1156
@zonyitoo zonyitoo mentioned this issue Apr 15, 2023
Merged
@zonyitoo
Copy link
Collaborator

zonyitoo commented Jul 1, 2023

Will be in next release v1.16

@zonyitoo zonyitoo closed this as completed Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zonyitoo @skeggse @xinlake