fix: don't ignore annotations when metadata.name doesn't exist (datre…

…eio#733) Co-authored-by: teselil <tzlil@datree.com>
shalev007 · Jul 20, 2022 · 291fe1d · 291fe1d
1 parent 4d52318
commit 291fe1d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/pkg/evaluation/evaluator.go b/pkg/evaluation/evaluator.go
@@ -356,10 +356,6 @@ func addFailedRule(currentFailedRulesByFiles FailedRulesByFiles, fileName string
 func extractSkipAnnotations(configuration extractor.Configuration) map[string]string {
 	skipAnnotations := make(map[string]string)
 
-	if configuration.MetadataName == "" || configuration.Kind == "" {
-		return nil
-	}
-
 	for annotationKey, annotationValue := range configuration.Annotations {
 		if strings.Contains(annotationKey, SKIP_RULE_PREFIX) {
 			skipAnnotations[annotationKey] = annotationValue.(string)

diff --git a/pkg/extractor/extractor.go b/pkg/extractor/extractor.go
@@ -130,9 +130,10 @@ func extractConfigurationK8sData(content []byte) Configuration {
 	if metadata := jsonObject["metadata"]; metadata != nil {
 		if metadataName := metadata.(map[string]interface{})["name"]; metadataName != nil {
 			configuration.MetadataName = metadataName.(string)
-			if annotations := metadata.(map[string]interface{})["annotations"]; annotations != nil {
-				configuration.Annotations = annotations.(map[string]interface{})
-			}
+		}
+
+		if annotations := metadata.(map[string]interface{})["annotations"]; annotations != nil {
+			configuration.Annotations = annotations.(map[string]interface{})
 		}
 	}