Prevent accidental upload

[borekb]

I have two computers with VSCode installed that I keep synchronized using this awesome extension. I have both autoUpload and autoDownload disabled (personal preference) so have to remember to upload / download manually.

If I'm not mistaken, download is safe: if I'm on a computer with newer settings (local only, not uploaded yet) and I invoke download, it will not overwrite my settings because sync.lastDownload equals what's in the Gist's cloudSettings lastUpload and silently finish (probably, I'm not 100% sure, there's a strict match instead of >=).

However, upload is not safe. Let's say both my machines are currently synchronized and I update settings on the first machine and upload. Now I come to the second machine and forget that I have to download first and I run upload straight away. This will upload my older settings from PC no. 2, losing changes done by PC no. 1 (well, I can get back the older settings from Gist but something bit troublesome just happened).

I'd propose making upload safe as well. For example, the extension could detect that my local settings are older than those on Gist (my local lastDownload is older than Gist's lastUpload) and warn me.

Also, if this is going to be implemented, I'd like to avoid repetitive uploads. Now, if I invoke upload 5 times, even though no settings actually changed, I will get 5 new revisions of the Gist. This is unnecessary, IMO.

---

IssueHunt Summary

shanalikhan has been rewarded.

Backers (Total: $50.00)

• issuehunt ($50.00)

Submitted pull Requests

• #965 V3.4.1

---

Tips

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on IssueHunt to raise funds.

---

IssueHunt has been backed by the following sponsors. Become a sponsor

[shanalikhan]

Yes you are right !

forceUpload when turned on it will always upload the settings without checking the gist version as #316.

But if user have the latest settings online and older settings in local.

It will show a message

Gist has newer version. Do you want to override the settings by enabling forceUpload ?

It will enable the forceUpload if user select OK

And Thanks for Providing the Scenarios !

[borekb]

Oh I completely forgot about that #316 issue :) Thank you so much for listening to feedback and improving the extension!

[fgallardograzio]

@borekb I referenced this issue in issue #396 because I'm thinking the extension could rely on git to provide version control, along with safe/force upload and download, since every gist is a git repo. What do you think?

[borekb]

@fgallardograzio thanks for the heads up, I'll post a comment there.

[quantuminformation]

Is there an option to override previous gists? I don't want to have loads of gists on github.

[IssueHuntBot]

@IssueHunt has funded $50.00 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

[shanalikhan]

@arnohovhannisyan
Can we fix this in next version?

[shanalikhan]

v3.4.0 has been fixed with this fix.
Let me know if there is any issue.

[borekb]

Great to hear! How is this fixed?

[shanalikhan]

the extension could detect that my local settings are older than those on Gist

If you have older settings in your computer comparing with updated Gist settings that were uploaded from other computer. It will not allow you to upload unless you download your settings first or select forceUpload to replace that Gist Settings.

[borekb]

Sounds great, thanks!

[borekb]

Update: when trying out the feature, it doesn't work well, see #1016 and #1035.