-
-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open Show "Share ID" Message when new Public Gist is created #977
Comments
Can you post your Settings Sync global settings. https://github.com/shanalikhan/code-settings-sync#global-settings |
Here they are:
|
Fixed in |
The notification showed again, sorry. |
alright, pls post the gist ID |
|
Can you post the details with the proper issue template so I can see the reproducing steps , happeing on upload / download etc. I have updated your main post so you can fill it up. |
Ok thanks, done |
I didn't find time to fix this issue. Hopefully, it will be fixed in upcoming releases. :) |
It is fixed and released in new version. |
* Fix korean * Fix: Ambiguous Expression and Korean naturally * Missing keys * Change `Sync :` to `Sync:` * dev.to post updated * #989 * Update package.nls.ko.json fixing some wrong translate. * Update ko-lang Although translated, it some case may not be accurate. * Fix GitHub spelling * chore(package): update @types/chai to version 4.2.0 * Update french translation file * Correcting the german translation Checking the translation based on the package.nls.json file Correcting the grammar for the german translation * Correcting typos Correcting spelling mistakes and typos * Correcting spelling mistakes Correcting more spelling mistakes * #974 * #977 #989 * #1003 (#1012) Also fix errors with settings containing backslashes. * #983 * #1008
Hello, Since the new release I see this message (but previously I wasn't). I see the checks on this changed in the last release: Previously the condition looked at the Since I don't see the calling signature is changed (as of the extension.ts L19-21) I would assume this is not how it should work? I think reverting the modification in the sync.ts L407 would solve the issue, or a direct check on - if (optArgument) {
+ if (optArgument === "publicGIST") { What is your thoughts on this @shanalikhan? |
yes are you right. I will place the check on
|
Ohh I see! I missed that part of the code, sorry :) |
Every time I open VSCode I have this notification:
How can I get rid of it permanently?
🌴 Visual Studio Code Version : 1.36.1
🌴 Code Settings Sync Version : 3.4.1
🌴 Standard or Insiders : Standard
🌴 Portable or Installed : Installed
🌴 OSS or Official Build : Official Build
🌴 Operating System : Windows 10
🌴 Occurs On: "Sync uploaded successfully" (each sync)
🌴 Proxy Enabled: yes (I guess it's default VSC value, I didn't change anything)
🌴 Gist Id: 1b8b7717469c2648bacb57a1498dd84e
📰 To Reproduce
Steps to reproduce the behavior:
Modify a setting and upload settings
💪 Expected behavior
No notification at each sync
📺 Console Error Log
📺 Additional context
gist
The text was updated successfully, but these errors were encountered: