Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Coder.com (#714) #720

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Add support for Coder.com (#714) #720

merged 1 commit into from
Dec 4, 2018

Conversation

deansheather
Copy link

Short description of what this resolves:

This adds support for the Coder.com VS Code Cloud IDE.

Changes proposed in this pull request:

  • Added the property isCoderCom to Environment
  • Added some setting overrides in a few places to settings that work for Coder.com
    • Force disable XDG home on Coder.com
    • Remove . in configSuffix
    • Force set the settings base path to /tmp, which resolves to /tmp/User
    • Force manual installation of extensions rather than using the CLI
  • Fixed an unrelated TS lint issue so it would pass the linter

Fixes: #714

How Has This Been Tested?

I tested the plugin on regular VS Code on a Windows machine with a simple settings.json file and 3-4 extensions. The settings file was uploaded from the Windows box and then downloaded into the Coder.com VS Code Cloud IDE using the extension, which worked. The synced extension installations worked as well.

I also tested this in the other direction, uploading the config from Coder.com and downloading to a regular IDE and this also worked.

Screenshots (if appropriate):

n/a

Checklist:

  • I have read the contribution guidelines.
  • My change requires a change to the documentation and Github Wiki.
  • I have updated the documentation and Wiki accordingly.

Checks for extension `coder.coder` to tell if the IDE is Coder + VS
Code or just a regular VS Code installation.
@shanalikhan shanalikhan added this to the v3.2.3 milestone Dec 4, 2018
@shanalikhan shanalikhan merged commit a71e09b into shanalikhan:v3.2.3 Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants