Avoid using chokidar (Fix #762)

[nekonenene]

Short description of what this resolves:

Fix "Extension host terminated unexpectedly" in Visual Studio Code v1.31.0 with Settings Sync.
( microsoft/vscode#64981 )

dyld: lazy symbol binding failed: Symbol not found: __ZN2v816FunctionTemplate3NewEPNS_7IsolateEPFvRKNS_20FunctionCallbackInfoINS_5ValueEEEENS_5LocalIS4_EENSA_INS_9SignatureEEEiNS_19ConstructorBehaviorENS_14SideEffectTypeE
  Referenced from: /Users/xxx/.vscode/extensions/shan.code-settings-sync-3.2.5/node_modules/fsevents/lib/binding/Release/node-v64-darwin-x64/fse.node
  Expected in: flat namespace

It causes by fsevents, also chokidar.
microsoft/vscode#65335

So, I remove chokidar from this repository, and use FileSystemWatcher .

Thanks: fabiospampinato/vscode-projects-plus@8357ab7#diff-b9cfc7f2cdf78a7f4b91a753d10865a2

Changes proposed in this pull request:

• Remove chokidar
  • disable depth setting because use FileSystemWatcher (sorry...)
• Update install_local.txt

Fixes: #762

How Has This Been Tested?

• Put console.log to check if pass through StartWatch, onDidChange, CloseWatch.
• Update locale.json (vscode setting), and see starting to upload. Check the gist file if update correctly.
• Update that 5 times, and every upload successfully finished.

Screenshots (if appropriate):

Checklist:

• I have read the contribution guidelines.
• My change requires a change to the documentation and GitHub Wiki.
• I have updated the documentation and Wiki accordingly.

[shanalikhan]

How are you handling the depth as 2 in File System Watcher

[nekonenene]

You mean the watcher should not watch under directories in workspaceStorage.
OK, I'll try handling it! Thanks.

[nekonenene]

@shanalikhan
Fixed by 758baf7
But it's not beautiful way... umm...

[shanalikhan]

It would be great if you can write details how are you handling these situations on FileSystemWatcher

[nekonenene]

The watcher doesn't watch the add event now, so I think it's not problem to ignore this option.

[nekonenene]

Now, I checked this behavior.
FileSystemWatcher and chokidar with ignoreInitial: true are same. 😄

Add the following code for check, and Added: logs are not appeared when the window reloads.

    Commons.configWatcher.onDidCreate(async (uri: vscode.Uri) => {
      const path: string = uri.path;
      console.log("Added: " + path);
    });

I also checked the case of ignoreInitial: false. nekonenene@5941286

[fuzzy76]

A much easier fix would be to bump chokidar to 2.1.0, as the problem is fixed in that release.

[nekonenene]

@fuzzy76
Did you rebuild and install code-settings-sync, and launch Visual Studio Code 1.31.0?
I already tried, and it causes the error sadly. 😢 ( #762 (comment) )

[shanalikhan]

It would personally recommend using vscode own file change events rather chokidar, when i developed this feature there were no api developed by code team thats why Settings Sync is using chokidar itself.

If new update of chokidar fix this problem, send new PR and i will accept that to push new version.
Meanwhile, i will test it and merge it soon.

[nekonenene]

@shanalikhan Thanks! So, should i close this PR?

[shanalikhan]

No, Keep this open, I will merge it soon.

[nekonenene]

Oh, I misunderstood your comment.

I hope that fsevents will update, and merge to chokidar. Thank you for merge.

[nekonenene]

Note: chokidar v2.1.1 is released yesterday, but, it includes fsevents v1.2.7 same as v2.1.0. I tried v2.1.1, and error occured.