Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Octokit deprecation warnings
Changes proposed in this pull request:
headers
is deprecated and we shouldn't use it.rejectUnauthorized
set to false is a security issue, and we shouldn't bother to find a workaround for it.code-settings-sync/src/service/githubService.ts
Line 49 in f698ce9
authenticate
function is deprecated and we should use theauth
option in the constructor of Octokit.https://github.com/octokit/rest.js#authentication
How Has This Been Tested?
Tested with "Launch extension" and
autoUpdate
on and off.Checklist: