Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(github): fix octokit warnings #783

Merged
merged 1 commit into from
Feb 26, 2019
Merged

fix(github): fix octokit warnings #783

merged 1 commit into from
Feb 26, 2019

Conversation

LuisUrrutia
Copy link
Contributor

Short description of what this resolves:

Octokit deprecation warnings

Changes proposed in this pull request:

How Has This Been Tested?

Tested with "Launch extension" and autoUpdate on and off.

Checklist:

  • I have read the contribution guidelines.
  • My change requires a change to the documentation and GitHub Wiki.
  • I have updated the documentation and Wiki accordingly.

@shanalikhan
Copy link
Owner

The authenticate function is deprecated and we should use the auth option in the constructor of Octokit.

Can you include this also in PR ?

@LuisUrrutia
Copy link
Contributor Author

That change it's already in this PR.

@shanalikhan shanalikhan added this to the v3.2.6 milestone Feb 26, 2019
@shanalikhan shanalikhan merged commit 999e6f0 into shanalikhan:v3.2.6 Feb 26, 2019
shanalikhan pushed a commit that referenced this pull request Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants