Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in ignoreUploadFolder #811

Merged
merged 1 commit into from
Apr 1, 2019

Conversation

knyhle
Copy link
Contributor

@knyhle knyhle commented Mar 27, 2019

Short description of what this resolves:

Fix a bug where it wasn't correctly ignoring folders if there was more than 1 folder in the list.

Changes proposed in this pull request:

  • change filter to fit function definition -- check if a file has a matched ignoreFolder

Fixes: #

How Has This Been Tested?

Add folder to ignored folder list. Check files are properly ignored.

Screenshots (if appropriate):

Before Fix:
beforecode

After Fix:
aftercode

Checklist:

  • I have read the contribution guidelines.
  • My change requires a change to the documentation and GitHub Wiki.
  • I have updated the documentation and Wiki accordingly.

@shanalikhan
Copy link
Owner

How Has This Been Tested? Add folder to ignored folder list. Check files are properly ignored.

Thanks, Can you post a screen shoot of what was the output of before this PR, so i can compare this one.

@knyhle
Copy link
Contributor Author

knyhle commented Mar 27, 2019

Hi, yeah I just updated the post. The 1st screenshot was the before the fix pic, the 2nd was the after.

Notice in the first screenshot how the workspace + .code-sync are in the ignored folders list, but the files after the filter still include them.

@shanalikhan
Copy link
Owner

Nice catch.

Thanks, Will release in next version.

@shanalikhan shanalikhan changed the base branch from master to v3.2.8 March 31, 2019 21:01
@shanalikhan shanalikhan added this to the v3.2.8 milestone Mar 31, 2019
@shanalikhan shanalikhan merged commit 75ceddd into shanalikhan:v3.2.8 Apr 1, 2019
@knyhle knyhle deleted the fix-ignoreuploadfolders branch April 3, 2019 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants