Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to vscode-chokidar [Updated] #834

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Switch to vscode-chokidar [Updated] #834

merged 1 commit into from
Apr 8, 2019

Conversation

auxves
Copy link
Contributor

@auxves auxves commented Apr 7, 2019

Short description of what this resolves:

This fixes issues with extension host being killed.

Changes proposed in this pull request:

  • Use the vscode-chokidar package instead of chokidar

Fixes: #827

How Has This Been Tested?

Tested by @WesCoder and @Spacebody

Checklist:

@shanalikhan shanalikhan added this to the v3.2.9 milestone Apr 8, 2019
@shanalikhan shanalikhan changed the base branch from master to v3.2.9 April 8, 2019 05:49
@shanalikhan shanalikhan merged commit c1e265c into shanalikhan:v3.2.9 Apr 8, 2019
@shanalikhan
Copy link
Owner

shanalikhan commented Apr 8, 2019

I am trying to build the package and getting this output from webpack.
Can you check?

image

@auxves
Copy link
Contributor Author

auxves commented Apr 8, 2019

Just fixed it. Making a new PR with the change.

shanalikhan pushed a commit that referenced this pull request Apr 9, 2019
* Switch to vscode-chokidar

* Include vscode-fsevents as an external
shanalikhan pushed a commit that referenced this pull request Apr 18, 2019
* Switch to vscode-chokidar

* Include vscode-fsevents as an external
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants