Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support more languages #898

Merged
merged 1 commit into from
May 29, 2019
Merged

Support more languages #898

merged 1 commit into from
May 29, 2019

Conversation

auxves
Copy link
Contributor

@auxves auxves commented May 29, 2019

Short description of what this resolves:

This PR adds support for 8 new languages to Settings Sync.

Changes proposed in this pull request:

  • Add support for 8 more languages
    • Spanish
    • French
    • Hungarian
    • Italian
    • Korean
    • Portuguese
    • Russian
    • Turkish

Checklist:

Note that these translations may not be 100% accurate and may need some revisions.

@auxves
Copy link
Contributor Author

auxves commented May 29, 2019

If anyone is wondering how I localized the package.nls.json file to many different languages, here you go: https://github.com/arnohovhannisyan/Localizer

@shanalikhan shanalikhan added this to the v3.3.0 milestone May 29, 2019
@shanalikhan shanalikhan merged commit 4bccd40 into shanalikhan:v3.3.0 May 29, 2019
@shanalikhan
Copy link
Owner

Merged, Thanks

@shanalikhan
Copy link
Owner

shanalikhan commented Jun 7, 2019 •
edited
Loading

@arnohovhannisyan

There are alot of files present in root folder. Can you send me a PR that will move these languages files to any folder like locals and read the files from that folder.
What do you think ? Regarding folder name or any further improvement.
We can add this in v3.3.0

image

@auxves
Copy link
Contributor Author

auxves commented Jun 7, 2019

@shanalikhan Sure, I'll start as soon as possible.

@auxves
Copy link
Contributor Author

auxves commented Jun 9, 2019

@shanalikhan I have run into an issue while attempting to move the localizations to a different folder. VSCode seems to only check in the root folder for them, so the top-level menus like Sync: Download Settings and others are not translated. Do you know how to get around this?

@shanalikhan
Copy link
Owner

Oh!!!
I also have to look into this. You can ask vscode team about it or checkout the other extensions code.

@auxves auxves deleted the new-languages branch June 19, 2019 11:05
@shanalikhan
Copy link
Owner

@arnohovhannisyan
Can you update this wiki with the new languages or improve the process for new users to improve and add their languages.
https://github.com/shanalikhan/code-settings-sync/wiki/Add-or-Improve-Language-Support

With the total languages Settings Sync support and pending ones.

shanalikhan pushed a commit that referenced this pull request Jun 24, 2019
@auxves @shanalikhan
Add new (but experimental) localizations (#898)
b18ce17
@auxves
Copy link
Contributor Author

auxves commented Jun 24, 2019

@shanalikhan I have updated the page to better fit the current status of the extension. However, I have also discovered an issue with the Portuguese localization file. The current name is package.nls.pt.json, while it should be package.nls.pt-br.json (according to this). I will be submitting a PR shortly fixing this issue.

shanalikhan pushed a commit that referenced this pull request Jul 1, 2019
@auxves @shanalikhan
#506
7257166 
* Updated to task api 2.0.0 and fixed tests

* Set "extensionKind": "ui" to support remote development #61

Fixes #870. See that issue for details

* Clean up previous commits into one

* #800 #515 #854

* Utilized pragmaUtil Functions for kb.json file

* Typo fix

* Added universalKeybindings setting

* chore(package): update @types/node to version 12.0.0 (#873)

* Cleaned up toggling commented settings (#877)

* Cleaned up toggling commented settings

* Updated to include fix by @ioprotium

* Fix warning with webpack

* Update UI

* Change height to max-height

* Add image locally and move it to the top

* Added documentation for tests in CONTRIBUTING.md (#881)

* fix(package): update fs-extra to version 8.0.0 (#882)

* chore(package): update @types/fs-extra to version 7.0.0 (#885)

* chore(package): update @types/node to version 12.0.1 (#883)

* fix(package): update fs-extra to version 8.0.1 (#884)

* Update UI to fit guidelines

* chore(package): update @types/node to version 12.0.2 (#887)

* Improve UI and functionality

* Match BG of theme and properly contrast text

* Fix issues with themes

* Fix image not showing up with light theme

* Fix issues with contrast

* Fix issue with VS Code's WebView

* Update UI and functionality

* Fix potential issue with light themes

* Fix issues with theme on modal

* Refactor

* Add new (but experimental) localizations (#898)

* chore(package): update clean-webpack-plugin to version 3.0.0 (#899)

*  #891

* Update settings page after a reset

* Improve code

* fix(clean-webpack-plugin): (#901)

clean-webpack-plugin was recently updated, and it had breaking changes.

* chore(package): update @types/node to version 12.0.3 (#897)

* #668

* fix(OSS):

enums.ts
----
Allow for setting os type with less code

environmentPath.ts
----
Find code folder and extensions folder more efficiently
Get OS type more efficiently

settings.ts
----
Ignore all state files

sync.ts
----
Adapt for changes in pluginService

pluginService.ts
----
Use vscode command to install extensions
Clean up code and simplify names

* Install extensions in order

* Comment legacy code instead of deleting it

* Fix extension install

* Fix issue with extensions always being deleted

* Get code path more efficiently

* Make sure to escape spaces in cli path

* Fix issues with portable builds

* Support Windows and certain editions

* Improve method for finding extension folder

* Start using API for installation

* Prepare for new API command

* Get ready for new API command

* Fix issue with installation

* Commit requested changes

* #668

* Format pluginService.ts (#906)

* #668

* Throw error

* Try to fix issues with getting missing

* chore(package): update @types/node to version 12.0.7 (#904)

* chore(package): update @types/node to version 12.0.8 (#908)

* #668

* #668

* #668

* #839

* Support multiple instances

* Completely switch to state

* Update to work properly

* Move setting classes to their own models

* Update service names

* Only auto upload using focused window

* Resolve merge conflicts

* #886

* Resolve locale properly

* Clean constructor

* Use state instead of passing in argument

* Update to be compatible with v3.3.0 changes

* Fix readme

* Fix package.json

* Add new settings

* Increase contrast

* Update

package.nls.*.json
----
Add localizations for setting names and placeholders.

github.oauth.service.ts
----
Handle errors in a more user-facing way
Support GitHub enterprise
Show message to user after success

webview.service.ts
----
Use new localizations for names and placeholders

* Bug fix and upload images

* Add support for commits to master (release notes)

* Fix issue

* Fix another issue with release notes

* Update release note template

* Update release notes

* Don't open gist selection if there aren't any gists

* Allow user to view gist

* Revert accidental change

* Support public gist

* Add css, js, and fonts to repo

* Improve font injection

* Revert accidental change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature-request 💡
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@auxves @shanalikhan