Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Done] Multi instance support #909

Merged
merged 7 commits into from
Jun 19, 2019
Merged

[Done] Multi instance support #909

merged 7 commits into from
Jun 19, 2019

Conversation

auxves
Copy link
Contributor

@auxves auxves commented Jun 14, 2019

Short description of what this resolves:

Add support for multiple instances of VSCode

Changes proposed in this pull request:

  • Only allow one instance of VS Code to auto-upload
  • Catch errors with lock file
  • Use extension state for storing environment, commons, and context

Fixes: #839

How Has This Been Tested?

I have tested it by installing it and running multiple instances of VS Code. Based on that, I can conclude that it should work great.

Checklist:

@auxves auxves changed the title [Needs Testing] Multi instance support [Done] Multi instance support Jun 14, 2019
@auxves
Copy link
Contributor Author

auxves commented Jun 14, 2019

@shanalikhan It should be ready to merge now. I have tested it by running multiple instances and making sure only one auto uploads.

@shanalikhan shanalikhan added this to the v3.3.0 milestone Jun 14, 2019
src/commons.ts Show resolved Hide resolved
src/models/state.model.ts Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
@shanalikhan shanalikhan merged commit 272273e into shanalikhan:v3.3.0 Jun 19, 2019
@auxves auxves deleted the multi-instance-support branch June 19, 2019 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants