Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lowercase aliases for currencies? #441

Closed
triallax opened this issue May 27, 2024 · 2 comments · Fixed by #571
Closed

Add lowercase aliases for currencies? #441

triallax opened this issue May 27, 2024 · 2 comments · Fixed by #571
Labels
good first issue

Comments

@triallax
Copy link
Contributor

As brought up in #319 (comment), do you think there are any good reasons not to add lowercase aliases for currencies (e.g. usd, gbp), for ease of use?
@sharkdp
Copy link
Owner

sharkdp commented May 27, 2024

No, I'm fine with that 👍

@andylima
Copy link

andylima commented Jul 9, 2024

I miss this feature too. I hope this can be added. 😃

@triallax triallax mentioned this issue Sep 18, 2024
Closed
triallax added a commit to triallax/numbat that referenced this issue Sep 18, 2024
@triallax
Add lowercase aliases for currency units
4bd188b 
Fixes sharkdp#441, `myr`/`rm` were not added due to conflict with `milliyear`/
`rontometer` respectively
@triallax triallax mentioned this issue Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add lowercase aliases for currency units triallax/numbat
3 participants
@sharkdp @andylima @triallax