Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OS X #12

Merged
merged 1 commit into from
Jun 28, 2016
Merged

Support OS X #12

merged 1 commit into from
Jun 28, 2016

Conversation

kpamnany
Copy link
Contributor

@kpamnany kpamnany commented Jun 28, 2016

Use relative addressing in the assembly code. Remove warning in strsplit example. Add clock_gettime() substitute for time_slice1 example. Don't use uname -o for Darwin in the makefiles. Tested on OS X 10.11.5/Core i7-4770HQ (x86_64) and for regressions on CentOS 7.1/Xeon E5-2699 v4 (x86_64).

I'd prefer to change the makefiles differently (don't use -o at all, instead use -a and findstring to parse the system name) but this is a more minimal change.

Edit: closes #9.

Use relative addressing in the assembly code. Remove warning in
strsplit example. Add clock_gettime() substitute for time_slice1
example. Don't use uname -o for Darwin in the makefiles. Tested
on OS X 10.11.5/Core i7-4770HQ (x86_64) and for regressions on
CentOS 7.1/Xeon E5-2699 v4 (x86_64).
@kpamnany
Copy link
Contributor Author

kpamnany commented Jun 28, 2016

Also tested on Arch Linux/Celeron 2955U (i686). Edit: sorry, it's an x86_64 platform. I have no access to any i686 machines to test.

@sharow
Copy link
Owner

sharow commented Jun 28, 2016

Thanks!! 🍺

I have tested on

  • ✅ FreeBSD x86_64 (amd64)
  • ✅ ArchLinux x86_64/i686
  • ✅ ArchLinuxARM armv7l/armv6l
  • ✅ OS X 10.11.5 x86_64

I'd prefer to change the makefiles differently (don't use -o at all, instead use -a and findstring to parse the system name) but this is a more minimal change.

what if hostname is CharlesDarwin or ... ok this seems to be rare case anyway :)

@sharow sharow merged commit a7eb125 into sharow:master Jun 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error compile on mac
2 participants