Enable VerifyCodeRefactoringOffered tests

The underlying requirement that diagnostics be waitable through FeatureAttribute.DiagnosticService was recently implemented (dotnet#24783), so these tests should be reliable again. Fixes dotnet#17393
sharwell · Feb 14, 2018 · 824d7c6 · 824d7c6
1 parent 56044ac
commit 824d7c6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/src/VisualStudio/IntegrationTest/IntegrationTests/CSharp/CSharpChangeSignatureDialog.cs b/src/VisualStudio/IntegrationTest/IntegrationTests/CSharp/CSharpChangeSignatureDialog.cs
@@ -21,14 +21,13 @@ public CSharpChangeSignatureDialog(VisualStudioInstanceFactory instanceFactory)
         {
         }
 
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/17393"),
-         Trait(Traits.Feature, Traits.Features.ChangeSignature)]
+        [Fact, Trait(Traits.Feature, Traits.Features.ChangeSignature)]
         public void VerifyCodeRefactoringOffered()
         {
             SetUpEditor(@"
 class C
 {
-    public void Method(int a, string b) { }
+    public void Method$$(int a, string b) { }
 }");
 
             VisualStudio.Editor.InvokeCodeActionList();

diff --git a/src/VisualStudio/IntegrationTest/IntegrationTests/VisualBasic/BasicChangeSignatureDialog.cs b/src/VisualStudio/IntegrationTest/IntegrationTests/VisualBasic/BasicChangeSignatureDialog.cs
@@ -22,8 +22,7 @@ public BasicChangeSignatureDialog(VisualStudioInstanceFactory instanceFactory)
         {
         }
 
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/17393"),
-         Trait(Traits.Feature, Traits.Features.ChangeSignature)]
+        [Fact, Trait(Traits.Feature, Traits.Features.ChangeSignature)]
         public void VerifyCodeRefactoringOffered()
         {
             SetUpEditor(@"