Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
y-zeng committed Aug 23, 2017
1 parent ee3e331 commit 2411bac
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 0 additions & 2 deletions include/grpc++/channel.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,7 @@ struct grpc_channel;

namespace grpc {
class ChannelConnectivityWatcher;
}

namespace grpc {
/// Channels represent a connection to an endpoint. Created by \a CreateChannel.
class Channel final : public ChannelInterface,
public CallHook,
Expand Down
3 changes: 2 additions & 1 deletion src/cpp/client/channel_cc.cc
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ void WatchStateChange(void* arg);
// support.
class ChannelConnectivityWatcher {
public:
ChannelConnectivityWatcher(Channel* channel)
explicit ChannelConnectivityWatcher(Channel* channel)
: channel_(channel), thd_id_(0), being_destroyed_(0) {}

void WatchStateChangeImpl() {
Expand All @@ -67,6 +67,7 @@ class ChannelConnectivityWatcher {
state = channel_->GetState(false);
}
}

void StartWatching() {
gpr_thd_options options = gpr_thd_options_default();
gpr_thd_options_set_joinable(&options);
Expand Down

0 comments on commit 2411bac

Please sign in to comment.