Skip to content

Commit

Permalink
Remove unnecessary notification
Browse files Browse the repository at this point in the history
  • Loading branch information
AspirinSJL committed Aug 13, 2019
1 parent 730b4f7 commit 3c28c5f
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions test/cpp/end2end/xds_end2end_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -924,7 +924,6 @@ TEST_F(SingleBalancerTest, Vanilla) {
EXPECT_EQ(kNumRpcsPerAddress,
backends_[i]->backend_service()->request_count());
}
balancers_[0]->eds_service()->NotifyDoneWithEdsCall();
// The EDS service got a single request, and sent a single response.
EXPECT_EQ(1U, balancers_[0]->eds_service()->request_count());
EXPECT_EQ(1U, balancers_[0]->eds_service()->response_count());
Expand All @@ -951,7 +950,6 @@ TEST_F(SingleBalancerTest, SameBackendListedMultipleTimes) {
// And they should have come from a single client port, because of
// subchannel sharing.
EXPECT_EQ(1UL, backends_[0]->backend_service()->clients().size());
balancers_[0]->eds_service()->NotifyDoneWithEdsCall();
}

TEST_F(SingleBalancerTest, SecureNaming) {
Expand Down Expand Up @@ -1022,7 +1020,6 @@ TEST_F(SingleBalancerTest, InitiallyEmptyServerlist) {
// populated serverlist but under the call's deadline (which is enforced by
// the call's deadline).
EXPECT_GT(ellapsed_ms.count(), kServerlistDelayMs);
balancers_[0]->eds_service()->NotifyDoneWithEdsCall();
// The EDS service got a single request.
EXPECT_EQ(1U, balancers_[0]->eds_service()->request_count());
// and sent two responses.
Expand All @@ -1041,7 +1038,6 @@ TEST_F(SingleBalancerTest, AllServersUnreachableFailFast) {
const Status status = SendRpc();
// The error shouldn't be DEADLINE_EXCEEDED.
EXPECT_EQ(StatusCode::UNAVAILABLE, status.error_code());
balancers_[0]->eds_service()->NotifyDoneWithEdsCall();
// The EDS service got a single request, and sent a single response.
EXPECT_EQ(1U, balancers_[0]->eds_service()->request_count());
EXPECT_EQ(1U, balancers_[0]->eds_service()->response_count());
Expand Down

0 comments on commit 3c28c5f

Please sign in to comment.