Merge pull request grpc#15086 from grpc/fix-channel-refcount

Fix _channel ref count issue
sheenaqotj · Apr 20, 2018 · 95fc9b8 · 95fc9b8
2 parents 2a6f473 + bc1a1b4
commit 95fc9b8
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/objective-c/GRPCClient/private/GRPCHost.m b/src/objective-c/GRPCClient/private/GRPCHost.m
@@ -108,7 +108,10 @@ - (nullable grpc_call *)unmanagedCallWithPath:(NSString *)path
                                    serverName:(NSString *)serverName
                                       timeout:(NSTimeInterval)timeout
                               completionQueue:(GRPCCompletionQueue *)queue {
-  GRPCChannel *channel;
+  // The __block attribute is to allow channel take refcount inside @synchronized block. Without
+  // this attribute, retain of channel object happens after objc_sync_exit in release builds, which
+  // may result in channel released before used. See grpc/#15033.
+  __block GRPCChannel *channel;
   // This is racing -[GRPCHost disconnect].
   @synchronized(self) {
     if (!_channel) {