Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading spinner's position #1300

Closed
DrDreave opened this issue Jul 10, 2020 · 2 comments · Fixed by #1360
Closed

Fix loading spinner's position #1300

DrDreave opened this issue Jul 10, 2020 · 2 comments · Fixed by #1360

Comments

@DrDreave
Copy link

Reproduction Link

Vue Multiselect

Steps to reproduce

  1. Trigger loading state in asynchronous select

Expected behaviour

The loading spinner should be positioned the same way as the dropdown arrow so there is a smooth transition between both states.

image

Actual behaviour

There is an offset between the spinner and the arrow.

image

Proposed fix

.multiselect__spinner {
  /* Same values as for .multiselect__select */
  width: 40px;
  height: 38px;
}
kenji7157 pushed a commit to kenji7157/vue-multiselect that referenced this issue Nov 3, 2020
kenji7157 pushed a commit to kenji7157/vue-multiselect that referenced this issue Nov 3, 2020
@kenji7157
Copy link
Contributor

@shentao
I tried contributing to the development of OSS. Is there something wrong with my fix?

@shentao
Copy link
Owner

shentao commented Nov 3, 2020

@kenji7157 Hey! I assume there’s nothing wrong with it. The only issue is that master is now pretty unstable, which prevents me from testing and building a new release.

@akki-jat akki-jat added this to the 2.1.7 release milestone Nov 7, 2022
@akki-jat akki-jat linked a pull request Nov 7, 2022 that will close this issue
akki-jat pushed a commit that referenced this issue Nov 7, 2022
Co-authored-by: “Kenji <“kawake.kk@gmail.com”>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants