Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add class when has-option-group #1567

Merged
merged 6 commits into from
Oct 26, 2022
Merged

Conversation

mrleblanc101
Copy link

Partial Fix #1474

@mattelen mattelen self-requested a review October 26, 2022 10:40
@mattelen
Copy link
Collaborator

This looks great and works nicely @mrleblanc101 - thanks for that. The only thing is that we don't want to update the build files, as they will be generated while creating the package. If you revert those changes, then we can merge this in. Thanks

@mrleblanc101
Copy link
Author

mrleblanc101 commented Oct 26, 2022

@mattelen Yes, sorry. I fixed it !
Another project I contributed had an action that required to commit the new dist file in the PR (which is odd, I know).

@mattelen mattelen merged commit ea397bf into shentao:master Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optiongroup children should be indented
2 participants