Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve issue #937: Uncaught error on backspace. #939

Merged
merged 1 commit into from
Mar 18, 2019

Conversation

phlegx
Copy link
Contributor

@phlegx phlegx commented Mar 6, 2019

No description provided.

@shentao
Copy link
Owner

shentao commented Mar 7, 2019

I wonder how this could be like this for so long. Anyway, would you be able to add a test case for that? I will try to prepare a release this weekend.

Thanks a lot for the contribution!

@phlegx
Copy link
Contributor Author

phlegx commented Mar 18, 2019

Hi @shentao! Why write a test?

this.internalValue[this.internalValue.length - 1] can only be made if this.internalValue.length is greater then zero. Access array on index -1 is not possible anyway.

@shentao shentao merged commit df04b4a into shentao:master Mar 18, 2019
@jackkoppa
Copy link

Thanks @phlegx for the fix, looks awesome. Will watch for the release; we definitely see this a fair amount in our usage

@TiborMalmo
Copy link

Thank you for the fix!

Is there any plans for when the next release is going to be live? 😄

@jessuni
Copy link

jessuni commented Apr 22, 2019

Hi @shentao! Any plans that this fix will be released soon? We've been getting the same error frequently.

@rubemlrm
Copy link

Hi @shentao , first of all great work on vue-multiselect. There is any plan to release this PR soon ?

@desaintflorent
Copy link

The 2.1.6 version has been released guys ! A couple of hours ago, and i can confirm the backspace bug is gone on my app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants