Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment Correction #41

Closed
xianrusso opened this issue Dec 30, 2018 · 1 comment
Closed

Comment Correction #41

xianrusso opened this issue Dec 30, 2018 · 1 comment

Comments

@xianrusso
Copy link

xianrusso commented Dec 30, 2018 •
edited
Loading

lines 87 - 89, commented out, state

User agent is needed because some sites does not
return the correct information because it thinks that
we are bot

which I think could tidied up to

A user agent is needed because some sites don't
return the correct information since they think that
we are bots

other than that tiny issue, i find your code very readable. great work and thanks for making a usable script!
sdushantha added a commit that referenced this issue Dec 30, 2018
@sdushantha
modified the comment about the user agent #41
57a4448
@sdushantha
Copy link
Member

i find your code very readable. great work and thanks for making a usable script!

Thank you, I really appreciate it! 😄

Yes, having nice and tidy comments are better.😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xianrusso @sdushantha