Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usernames with "." #9

Closed
plgrazon opened this issue Dec 26, 2018 · 6 comments
Closed

usernames with "." #9

plgrazon opened this issue Dec 26, 2018 · 6 comments
Labels
bug Something isn't working

Comments

@plgrazon
Copy link

It breaks when I search for a username that has a dot/period

@sdushantha sdushantha added the bug Something isn't working label Dec 26, 2018
@sdushantha
Copy link
Member

sdushantha commented Dec 26, 2018

You are right, I tried a username with a period and I got some strange error when it tries AngleList. Its strange though, when I visit https://angel.co/siddharth.dushantha I get a user, but if I make Python do it, I get nothing.

import requests

headers = {
    'User-Agent': 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:55.0) Gecko/20100101 Firefox/55.0'
}

r = requests.get("https://angel.co/siddharth.dushantha")

r.status_code
# 404

r.text
# ''

Edit: Do you know whats going on?

@hldh214
Copy link

hldh214 commented Dec 26, 2018

possible missing headers=headers?

import requests

headers = {
    'User-Agent': 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:55.0) Gecko/20100101 Firefox/55.0'
}

r = requests.get("https://angel.co/siddharth.dushantha", headers=headers)

print('Siddharth Sivaraman' in r.text)
# True

@sdushantha
Copy link
Member

@hldh214
Thank you! I did not see that.

sdushantha added a commit that referenced this issue Dec 26, 2018
@sdushantha
Copy link
Member

fixed it :)

@hoadlck
Copy link
Contributor

hoadlck commented Dec 26, 2018

After this change, any site that has the "noPeriod" attribute set to "True" in the json incorrectly says that the user name is not supported. Even if they do not have a period set in their user name.

The if statement needs to check if there could even be a problem before doing the continue. I will submit another pull request...

@sugizo
Copy link

sugizo commented Jan 5, 2019

test on ubuntu with Python 3.6.7
python3 sherlock.py username.123

return:

  • Facebook: Illegal Username Format For This Site!
  • Wix: Error!
  • Error Connecting: Crevado

here is the complete list:
[-] Facebook: Illegal Username Format For This Site!
[-] Blogger: Illegal Username Format For This Site!
[-] GitHub: Illegal Username Format For This Site!
[-] DeviantART: Illegal Username Format For This Site!
[-] Flipboard: Illegal Username Format For This Site!
[-] Kongregate: Illegal Username Format For This Site!
[-] LiveJournal: Illegal Username Format For This Site!
[-] Dribbble: Illegal Username Format For This Site!
[-] Newgrounds: Illegal Username Format For This Site!
[-] Contently: Illegal Username Format For This Site!
[-] Slack: Illegal Username Format For This Site!
[-] WordPress: Illegal Username Format For This Site!
[-] Error Connecting: Wix
[-] Wix: Error!
[-] Error Connecting: Crevado
[-] Crevado: Error!
[-] Error Connecting: Carbonmade
[-] Carbonmade: Error!
[-] Coroflot: Not Found!
[-] Error Connecting: Jimdo
[-] Jimdo: Error!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants