Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style fixes in comments #1206

Merged
merged 3 commits into from
Dec 10, 2021
Merged

Style fixes in comments #1206

merged 3 commits into from
Dec 10, 2021

Conversation

nblanke
Copy link
Contributor

@nblanke nblanke commented Dec 7, 2021

-make the comment style more consistent by replacing Nothing with N/A
-fix typo in sherlock.py

@sdushantha
Copy link
Member

Wouldn't "Nothing" be more correct? Because N/A stands for Not Available and the return value is in a way not available because it is "nothing" :P

I have nothing against this change but just curious to know why "N/A" may be better than "Nothing"

@nblanke
Copy link
Contributor Author

nblanke commented Dec 10, 2021

For a function that returns None, both "N/A" and "Nothing" were used in the docstring.
Since most of the docstrings used "N/A" instead of "Nothing" I replaced "Nothing" with "N/A".
But you're correct, using "Nothing" makes more sense.

@sdushantha sdushantha merged commit aef2711 into sherlock-project:master Dec 10, 2021
@nblanke nblanke deleted the style-fixes branch December 11, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants