Refactoring of the no-color flag #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdushantha
requested changes
Dec 26, 2021
Comment on lines
+587
to
+594
|
|
||
| if args.no_color: | ||
| # Disable color output. | ||
| init(strip=True, convert=False) | ||
| else: | ||
| # Enable color output. | ||
| init(autoreset=True) | ||
|
|
There was a problem hiding this comment.
Would this be a better solution?
if not args.no_color:
init(autoreset=True)So by default color is on. If --no-color is used, then init(autoreset=True) is skipped because of the condition in the if statement.
There was a problem hiding this comment.
On my machine (OS X) that doesn't work. Even with the no-color flag, colored output is displayed. The reason for this behavior is that init() converts ANSI characters to win32 calls. That has no effect on Linux/OS X because there, colorama does nothing.
sdushantha
approved these changes
Mar 10, 2022
|
Sorry for getting back to you so late. Everything looks good to me and I'll merge this PR right away. I really appreciate you taking the time and effort into doing the refactoring |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the handling of the no-color flag by enabling/disabling color output with the colorama.init() function, thus making the if statements to check for color output redundant. Therefore, the code is more concise and clean.