Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label the Docker image with some VCS repository information #201

Merged

Conversation

nstapelbroek
Copy link
Contributor

@nstapelbroek nstapelbroek commented Apr 24, 2019

Heya,

To link the of the image published on Docker Hub with the git revision I've introduced some labels in the image. This should help identifying mismatches between container and repository versions faster like in the case of #175.

What has been done:

How to test:

  • Build image with docker build -t mysherlock-image . --build-arg VCS_REF=$(git rev-parse HEAD)
  • Acknowledge that docker image inspect mysherlock-image will show the labels
  • Build the image without the build-arg, notice that it does not break the build.

Let me know if you want anything changed. Thank you for the awesome project 😄

@TheYahya TheYahya merged commit 318ff28 into sherlock-project:master Apr 28, 2019
@TheYahya
Copy link
Contributor

Thank you @nstapelbroek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants