Added options to connect over TOR #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Noticed that the CSV PR made that this PR had merge conflicts. Just resolved those, so it is ready to be merged again as far as I'm concerned :-) |
|
Thanks for rebasing your development. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added options to connect over TOR.
Full explanation
For those who value privacy, it might be important to be able to connect over TOR. This PR adds two command line arguments:
As connecting over TOR is only possible when TOR is installed/in the system PATH, this requirement is also referred to in the documentation of the CL arguments. The documentation now also mentions that connecting over TOR (especially establishing new circuits) adds to the runtime of the program.
Finally, as can happen with any IP, some services might decide to block requests coming from known TOR exit nodes. This might increase connection errors and thus a warning message was added to inform the user about this potential consequence.