Support HTTP Status Detection GET Override. Use For Instagram #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfigure Instagram to use this option. In most cases when we are detecting by status code, it is not necessary to get the entire body: we can detect fine with just the HEAD response. However, Richard Getz discovered that some sites (e.g. Instagram) will not respond properly if Sherlock only requests the HEAD. Add a "request_head_only" attribute to the data.json so HTTP Status Detection can be configured either way. It is simpler to support this change in this fashion, as it does not require changes to the tests. With Richard Getz <richardgetziii@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a restructuring of #593.
Add override to HTTP Status Detection so HEAD request is not used. Configure Instagram to use this option.
In most cases when we are detecting by status code, it is not necessary to get the entire body: we can detect fine with just the HEAD response. However, Richard Getz discovered that some sites (e.g. Instagram) will not respond properly if Sherlock only requests the HEAD.
Add a "request_head_only" attribute to the data.json so HTTP Status Detection can be configured either way. It is simpler to support this change in this fashion, as it does not require changes to the tests.
With Richard Getz richardgetziii@gmail.com