-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script for installing packages in linux #72
Script for installing packages in linux #72
Conversation
As requested, I'll give a brief overview of what I think the problem is and how you can fix it. Feel free to ask questions, especially if you don't fully understand any of the terminology (branch vs fork, etc.). Background InfoA fork is essentially a copy of this main repo that you have full control over. When you make changes to the code, you don't actually have permission to push that code to branches on @TheYahya's repo. Instead, you made a copy of the entire repo and push your changes to that copy. When you submit a PR on GitHub, you are essentially "requesting" @TheYahya to "pull" the changes from a specific branch in your repo into Notice the blue fields specify The ProblemLooking at your fork, the problem is that you worked on PR #64 directly on your fork's You did that for this PR (you used branch Fixing the IssueBecause PR #64 is still open and is based directly of your fork's So we'll have to workaround this. Essentially what we want to do is "delete" the 2nd to last commit (the "regexCheck" commit) but "keep" the last commit (the "linux script") on this branch. To do so, we will actually "delete" both commits and "re-copy" the last commit manually. More specifically, we will:
Here's the commands to do so. Please make sure you're on the
Don't worry if you mess up! I made a copy of your work and can restore it if you accidentally delete it ;) |
Thank you so much. I will try it later today, but what about my master branch? How can I change it to be up-to-date but this will not affect both PRs? |
We can't change the master branch until PR #64 is either merged or closed. As soon as that happens, we can change it! |
You will need to use cmd to run all the above operations (github doesn't support this advanced setup), but your previous changes will be fine. All those changes will show up locally. Just make sure you cloned your fork, as that has the changes. Do not clone the main repo. After cloning, checkout the Then run |
Thank you so much again. It would be done as soon as possible! :) |
The script downloads the packages that are necessary for the sherlock.py. It is an automated procedure instead of the instructions in the README.md. It contains some packages that are not in README but I couldn't run "pip3 install -r requirements.txt" without them. It is for linux, I don't know if it works on something else. I believe it is useful!
f84629c
to
f7f36b5
Compare
I think I did it! Please, tell me if there is a problem again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Thanks for your contribution, I have merged it. Let me know if anything else about git/github is unclear! |
Everything is clear now, your explenations were crystal clear! :) |
The script downloads the packages that are necessary for the sherlock.py. It is an automated procedure instead of the instructions in the README.md.
It contains some packages that are not in README but I couldn't run "pip3 install -r requirements.txt" without them.
It is for linux, I don't know if it works on something else.
I believe it is useful!
Sorry for the extra files from previous pull request (if they are shown), but I'm new on Github and I' confused with commits and forks.