Update sidebaritems.ts to fix Account request label (sourcegraph#49178)

* Update admin routes to "/account-requests" Co-authored-by: Erzhan Torokulov <erzhan.torokulov@gmail.com>
shershams · Mar 21, 2023 · 4bc4234 · 4bc4234
1 parent d05d8db
commit 4bc4234
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/client/web/src/site-admin/AccessRequestsPage/AccessRequestsGlobalNavItem.tsx b/client/web/src/site-admin/AccessRequestsPage/AccessRequestsGlobalNavItem.tsx
@@ -44,7 +44,7 @@ export const AccessRequestsGlobalNavItem: React.FunctionComponent<AccessRequests
         <ButtonLink
             variant="success"
             size="sm"
-            to="/site-admin/access-requests"
+            to="/site-admin/account-requests"
             className="d-flex align-items-center py-1"
         >
             <Icon svgPath={mdiAccountPlus} size="md" aria-label="Account requests icons" color="var(--success-2)" />

diff --git a/client/web/src/site-admin/routes.tsx b/client/web/src/site-admin/routes.tsx
@@ -148,7 +148,7 @@ export const otherSiteAdminRoutes: readonly SiteAdminAreaRoute[] = [
         render: props => <SiteAdminOrgsPage {...props} />,
     },
     {
-        path: '/access-requests',
+        path: '/account-requests',
         render: () => <AccessRequestsPage />,
         condition: context =>
             checkRequestAccessAllowed(

diff --git a/client/web/src/site-admin/sidebaritems.ts b/client/web/src/site-admin/sidebaritems.ts
@@ -115,8 +115,8 @@ export const usersGroup: SiteAdminSideBarGroup = {
             to: '/site-admin/users',
         },
         {
-            label: 'Access requests',
-            to: '/site-admin/access-requests',
+            label: 'Account requests',
+            to: '/site-admin/account-requests',
             condition: context =>
                 checkRequestAccessAllowed(
                     context.isSourcegraphDotCom,

diff --git a/doc/admin/auth/index.md b/doc/admin/auth/index.md
@@ -75,7 +75,7 @@ You can use the filter `allowSignup`, available in the builtin configuration, to
 
   If set to `true`, users will see a sign-up link under the login form and will have access to the sign-up page, where they can create their accounts without restriction.
 
-  When not set, it will default to `false` -- in this case, users will see request access link. Unauthenticated users can submit request access forms and admins will get notification on the instance which they can approve or reject. Access request feature can be disabled by setting `experimentalFeatures.accessRequest.enabled: false`, and in this case new user accounts should be created by the site admin manually.
+  When not set, it will default to `false` -- in this case, users will see request access link. Unauthenticated users can submit request access forms and admins will get notification on the instance which they can approve or reject. Account request feature can be disabled by setting `experimentalFeatures.accessRequest.enabled: false`, and in this case new user accounts should be created by the site admin manually.
 
   If you choose to block sign-ups by using the `allowSignup` filter avaliable in another auth provider (eg., [GitHub](#how-to-control-user-sign-up-and-sign-in-with-github-auth-provider) or [GiLab](#how-to-control-user-sign-up-and-sign-in-with-gitlab-auth-provider)), make sure this builtin filter is removed or set to `false`. Otherwise, users will have a way to bypass the restriction.