Building with Clang on Windows #300
Conversation
Configure.cmake
Outdated
| if (NOT LIBM) | ||
| set(LIBM "") | ||
| endif() | ||
| if (NOT SLEEF_CLANG_ON_WINDOWS) |
There was a problem hiding this comment.
I don't get this - why do you need to customize this for clang on windows? If the libraryes are not available, the variables below (LIB_MPFR, LIBFFTW3, ..) would evaluate to false and teh corresponding compilation flags will not be set. Is that breaking things?
There was a problem hiding this comment.
CMake finds libraries for Cygwin, and this causes build errors.
We need to check the builds with Cygwin testers.
There was a problem hiding this comment.
May I ask you to add this explanation as a comment? It will help people like me who doesn't know much about compiling on windows in understanding why there is this if not clang_on_windows condition.
src/quad/CMakeLists.txt
Outdated
| @@ -60,7 +60,7 @@ foreach(SIMD ${SLEEFQUAD_SUPPORTED_EXT}) | |||
| endif() | |||
| endforeach() | |||
|
|
|||
| if(MSVC OR MINGW AND WIN32) | |||
| if(MSVC OR SLEEF_CLANG_ON_WINDOWS OR MINGW AND WIN32) | |||
There was a problem hiding this comment.
Why is this condition different from the one if((MSVC OR MINGW AND WIN32) OR SLEEF_CLANG_ON_WINDOWS) 25 of src/libm/CMakeLists.txt?
Configure.cmake
Outdated
| string(COMPARE NOTEQUAL "" "$ENV{TRAVIS}" RUNNING_ON_TRAVIS) | ||
| string(COMPARE NOTEQUAL "" "$ENV{APPVEYOR}" RUNNING_ON_APPVEYOR) |
There was a problem hiding this comment.
Please make these variables to be set at cmake invocation, as in cmake -DRUNNING_ON_TRAVIS=On .... It is safer than having to deal with things breaking in the case the name of the env variable change.
With this patch, the library can be built with Clang on Windows.