Mark Sleef_rempitabq* constants as static #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without marking it static, it fails to compile when including multiple sleefinline_*.h into the same compilation unit.
|
Would you mind adding static to
This should already be addressed by the include guard around the rempi tables. Are you sure the issue isn't from linking multiple objects that all included the header and use the table? |
|
@joeramsay fixed. |
|
Thanks, looks good to me (I don't have commit rights here though) |
|
@blapie hi, what would be the path forward for this? Thanks! |
|
Hi @luhenry, it should be possible to move this on soon (see #537 (comment)) |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without marking it static, it fails to compile when including multiple sleefinline_*.h into the same compilation unit.
Co-Authored-By: Hamlin Li hamlin@rivosinc.com