Skip to content

Commit

Permalink
Apply Leandro Lucarella <llucax@gmail.com>'s patches for VIM highligh…
Browse files Browse the repository at this point in the history
…ting

and not setting execute bit on protoc outputs.
  • Loading branch information
temporal committed Jul 31, 2008
1 parent 24856db commit 8ccb790
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
1 change: 1 addition & 0 deletions CONTRIBUTORS.txt
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,4 @@ Non-Google patch contributors:
Kevin Ko <kevin.s.ko@gmail.com>
Johan Euphrosine <proppy@aminche.com>
Ulrich Kunitz <kune@deine-taler.de>
Leandro Lucarella <llucax@gmail.com>
10 changes: 9 additions & 1 deletion editors/proto.vim
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@
" augroup filetype
" au! BufRead,BufNewFile *.proto setfiletype proto
" augroup end
"
" Or just create a new file called ~/.vim/ftdetect/proto.vim with the
" previous lines on it.

if version < 600
syntax clear
Expand All @@ -32,6 +35,9 @@ endif

syn case match

syn keyword pbTodo contained TODO FIXME XXX
syn cluster pbCommentGrp contains=pbTodo

syn keyword pbSyntax syntax import option
syn keyword pbStructure package message group
syn keyword pbRepeat optional required repeated
Expand All @@ -50,7 +56,7 @@ syn match pbInt /\<0[xX]\x+\>/
syn match pbFloat /\<-\?\d*\(\.\d*\)\?/
" TODO: .proto also supports C-style block comments;
" see /usr/share/vim/vim70/syntax/c.vim for how it's done.
syn match pbComment /\/\/.*$/
syn region pbComment start="//" skip="\\$" end="$" keepend contains=@pbCommentGrp
syn region pbString start=/"/ skip=/\\"/ end=/"/
syn region pbString start=/'/ skip=/\\'/ end=/'/

Expand All @@ -62,6 +68,8 @@ if version >= 508 || !exists("did_proto_syn_inits")
command -nargs=+ HiLink hi def link <args>
endif

HiLink pbTodo Todo

HiLink pbSyntax Include
HiLink pbStructure Structure
HiLink pbRepeat Repeat
Expand Down
2 changes: 1 addition & 1 deletion src/google/protobuf/compiler/command_line_interface.cc
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ io::ZeroCopyOutputStream* CommandLineInterface::DiskOutputDirectory::Open(
do {
file_descriptor =
open((root_ + filename).c_str(),
O_WRONLY | O_CREAT | O_TRUNC | O_BINARY, 0777);
O_WRONLY | O_CREAT | O_TRUNC | O_BINARY, 0666);
} while (file_descriptor < 0 && errno == EINTR);

if (file_descriptor < 0) {
Expand Down

0 comments on commit 8ccb790

Please sign in to comment.