Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker version #258

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Fix docker version #258

merged 4 commits into from
Sep 23, 2024

Conversation

robindiddams
Copy link
Contributor

@robindiddams robindiddams commented Sep 23, 2024 •
edited
Loading

Fixes docker build to use correct version and also not $GIT_SHA

@robindiddams robindiddams changed the title pass the sha in correctly Proper Build Args Sep 23, 2024
@robindiddams robindiddams changed the title Proper Build Args Fix docker version Sep 23, 2024
@robindiddams robindiddams merged commit c0637de into main Sep 23, 2024
3 checks passed
@robindiddams robindiddams deleted the fix-build branch September 23, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhaynie jhaynie jhaynie approved these changes

@potofpie potofpie Awaiting requested review from potofpie

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robindiddams @jhaynie