refactor(shorebird_cli): AotTools process execution and error reporting
#2503
+220
−180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
eseidel
reviewed
Sep 30, 2024
| /// {@template aot_tools_execution_failure} | ||
| /// Exception thrown when aot_tools execution exits with a non-zero exit code. | ||
| /// {@endtemplate} | ||
| class AotToolsExecutionFailure implements Exception { |
There was a problem hiding this comment.
This has really little to do with aottools, but it's fine to start with something specific for now and make it generic later.
There was a problem hiding this comment.
Yup happy to look at the rest of our wrappers and see if we can unify things a bit more in a subsequent PR 👍
eseidel
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AotToolsprocess execution and error reportingType of Change