fix: change "Creating Artifacts" to "Uploading Artifacts" #2516
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Customers sometimes get stuck on the "Creating Artifacts" step which I believe to be due to networking issues. Saying "Uploading" instead of Creating might help customers understand that the network is involved in the "creation".
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
felangel
reviewed
Oct 8, 2024
| @@ -412,7 +412,7 @@ Please create a release using "shorebird release" and try again. | |||
| required Iterable<Arch> architectures, | |||
| String? flavor, | |||
| }) async { | |||
| final createArtifactProgress = logger.progress('Creating artifacts'); | |||
| final createArtifactProgress = logger.progress('Uploading artifacts'); | |||
There was a problem hiding this comment.
Suggested change
| final createArtifactProgress = logger.progress('Uploading artifacts'); | |
| final uploadArtifactProgress = logger.progress('Uploading artifacts'); |
can we rename the variable for consistency?
There was a problem hiding this comment.
Actually it might be better to split this into two parts (creating and uploading) for more transparency and improved accuracy? wdyt?
There was a problem hiding this comment.
In many cases the "creating" is the calling of the API, which implicitly does the "uploading".
|
Interesting, Releaser splits into buildReleaseArtifacts and uploadReleaseArtifacts, where as patcher just has buildPatchArtifact and createPatchArtifacts |
felangel
reviewed
Oct 8, 2024
| @@ -511,7 +511,7 @@ aab artifact already exists, continuing...''', | |||
| required String extractedAarDir, | |||
| required Iterable<Arch> architectures, | |||
| }) async { | |||
| final createArtifactProgress = logger.progress('Creating artifacts'); | |||
| final createArtifactProgress = logger.progress('Uploading artifacts'); | |||
There was a problem hiding this comment.
Suggested change
| final createArtifactProgress = logger.progress('Uploading artifacts'); | |
| final uploadArtifactProgress = logger.progress('Uploading artifacts'); |
felangel
reviewed
Oct 8, 2024
| @@ -606,7 +606,7 @@ aar artifact already exists, continuing...''', | |||
| required bool isCodesigned, | |||
| required String? podfileLockHash, | |||
| }) async { | |||
| final createArtifactProgress = logger.progress('Creating artifacts'); | |||
| final createArtifactProgress = logger.progress('Uploading artifacts'); | |||
There was a problem hiding this comment.
Suggested change
| final createArtifactProgress = logger.progress('Uploading artifacts'); | |
| final uploadArtifactProgress = logger.progress('Uploading artifacts'); |
felangel
reviewed
Oct 8, 2024
| @@ -658,7 +658,7 @@ aar artifact already exists, continuing...''', | |||
| required int releaseId, | |||
| required String appFrameworkPath, | |||
| }) async { | |||
| final createArtifactProgress = logger.progress('Creating artifacts'); | |||
| final createArtifactProgress = logger.progress('Uploading artifacts'); | |||
There was a problem hiding this comment.
Suggested change
| final createArtifactProgress = logger.progress('Uploading artifacts'); | |
| final uploadArtifactProgress = logger.progress('Uploading artifacts'); |
felangel
reviewed
Oct 8, 2024
| @@ -138,7 +138,7 @@ class AarPatcher extends Patcher { | |||
| ); | |||
| final patchArtifactBundles = <Arch, PatchArtifactBundle>{}; | |||
|
|
|||
| final createDiffProgress = logger.progress('Creating artifacts'); | |||
| final createDiffProgress = logger.progress('Uploading artifacts'); | |||
There was a problem hiding this comment.
Suggested change
| final createDiffProgress = logger.progress('Uploading artifacts'); | |
| final uploadArtifactsProgress = logger.progress('Uploading artifacts'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customers sometimes get stuck on the "Creating Artifacts" step
which I believe to be due to networking issues. Saying
"Uploading" instead of Creating might help customers understand
that the network is involved in the "creation".