Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Reason consts #48

Closed
powerman opened this issue Nov 12, 2016 · 1 comment
Closed

Missing Reason consts #48

powerman opened this issue Nov 12, 2016 · 1 comment
Labels
bug

Comments

@powerman
Copy link

Comparing to current https://developer.apple.com/library/content/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/CommunicatingwithAPNs.html#//apple_ref/doc/uid/TP40008194-CH11-SW1 these are missing (probably only first is valid for this package):

BadCollapseId
ExpiredProviderToken
InvalidProviderToken
MissingProviderToken
TooManyProviderTokenUpdates
@sideshow
Copy link
Owner

Great catch, looks like Apple have updated the reason code table.
Will add these before merging #43

@sideshow sideshow added the bug label Nov 13, 2016
sideshow added a commit that referenced this issue Nov 26, 2016
@sideshow
Add missing Reason constants
708a769 
- Fixes #48 by adding the missing constants, and also updates the rest
of the status codes and descriptions to be the same as Table 8-6 in the
Apple docs.
@sideshow sideshow mentioned this issue Nov 26, 2016
Merged
sideshow added a commit that referenced this issue Nov 26, 2016
@sideshow
Add missing Reason constants
2e27647 
- Fixes #48 by adding the missing constants, and also updates the rest
of the status codes and descriptions to be the same as Table 8-6 in the
Apple docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sideshow @powerman