Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix test file name #2530

Merged
merged 2 commits into from
Mar 26, 2024
Merged

ci: fix test file name #2530

merged 2 commits into from
Mar 26, 2024

Conversation

wellwelwel
Copy link
Collaborator

Fixes:

Screenshot 2024-03-26 at 02 51 43

@sidorares
Copy link
Owner

unrelated, but it's probably time to drop node 14.x and 16.x from the matrix

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.20%. Comparing base (d9dccfd) to head (38280ac).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2530   +/-   ##
=======================================
  Coverage   91.19%   91.20%           
=======================================
  Files          69       69           
  Lines       15534    15547   +13     
  Branches     1331     1331           
=======================================
+ Hits        14166    14179   +13     
  Misses       1368     1368           
Flag Coverage Δ
compression-0 91.20% <ø> (+<0.01%) ⬆️
compression-1 91.20% <ø> (+<0.01%) ⬆️
tls-0 90.71% <ø> (+<0.01%) ⬆️
tls-1 91.02% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wellwelwel
Copy link
Collaborator Author

unrelated, but it's probably time to drop node 14.x and 16.x from the matrix

I'll open a new PR for this 🙋🏻‍♂️


Also, @sidorares, can you check the Codecov app? It's actually warning:

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@wellwelwel wellwelwel merged commit bd30872 into sidorares:master Mar 26, 2024
70 checks passed
@sidorares
Copy link
Owner

I clicked "install", not sure where this is visible i codecov settings. I guess we'll validate this in the next codecov report comment

@wellwelwel
Copy link
Collaborator Author

wellwelwel commented Mar 26, 2024

I clicked "install", not sure where this is visible i codecov settings. I guess we'll validate this in the next codecov report comment

It worked 🎉

Screenshot 2024-03-26 at 03 33 08

@wellwelwel wellwelwel deleted the rebase-test branch April 2, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants