Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve importation progress text #70

Closed
wants to merge 1 commit into from
Closed

Conversation

MLZ94
Copy link

@MLZ94 MLZ94 commented Sep 6, 2023

Much useful when it comes to big playlists, when updating infos every 10 tracks, sometimes it can feel like something is going wrong because it takes too long. This way we can precisely know the progress.
It is also more pleasent when it's a single line updating rather than several lines on the terminal

Much useful when it comes to big playlists, when updating infos every 10 tracks,
sometimes it can feel like something is going wrong because it takes too long.
This way we can precisely know the progress.
It is also more pleasent when it's a single line updating rather than several lines on the terminal

Signed-off-by: MLZ94 <zugutoroberto@gmail.com>
@sigma67
Copy link
Owner

sigma67 commented Sep 7, 2023

I feel like this goes too far, you could simply remove the %10 in the if statement instead.

But I'd like to make this optional, for example add a --verbose option that enables detailed logging. Could even add more output:

YTMusic: Searching for <search term> (<x>/<total>)

@MLZ94
Copy link
Author

MLZ94 commented Sep 7, 2023

Actually the main idea was to make the text dynamicaly updating at the same line (like a progress bar) rather than printing new and new lines, so that doesn't go too far for that purpose. And yeah, it's a good idea to add more output, i'll probably give it a try
But only removing the % 10 is not my idea, i wanted to make it feel more reactive and with less output lines (which is cleaner, one single progress line rather than many, could go very far for big playlist, the one i use has almost 90 musics)

@sigma67
Copy link
Owner

sigma67 commented Sep 7, 2023

Sorry, the flush will not be merged. The output shall be sequential

@sigma67 sigma67 closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants