Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create single script for batch transfers, refactor Setup.py and Youtube.py #9

Closed
wants to merge 2 commits into from

Conversation

PattoMotto
Copy link

  • Refactor Setup.py and Youtube.py so they can be called from another script.
  • Create SpotifyToYoutube.py which requires youtube_headers_raw.txt and spotify_playlists.txt
  • Add example
  • Update documents

@sigma67
Copy link
Owner

sigma67 commented Nov 28, 2020

Looks like some useful changes at first glance, although a bit difficult to compare since so many things were changed.

Is it backwards compatible with existing setups?

@PattoMotto
Copy link
Author

PattoMotto commented Nov 29, 2020

@sigma67
I upgraded the Setup script.

Before
python Setup.py musicmanager
After
python Setup.py --musicmanager OR python Setup.py -mm

Before
python Setup.py mobileclient
After
python Setup.py --mobileclient OR python Setup.py -mc

Before
python Setup.py youtube
After
python Setup.py --youtube OR python Setup.py -yt

And the new headers_raw
python Setup.py --youtube --headers_raw "HEADERS"

Please let me know if you've any concerns with this upgrade.

@sigma67
Copy link
Owner

sigma67 commented Nov 30, 2020

Yes, but that's not all you changed. There's also many changes to YouTube.py. You also didn't answer my question about backwards compatibility.

@PattoMotto
Copy link
Author

There's also many changes to YouTube.py. You also didn't answer my question about backwards compatibility.

YouTube.py will be 100% backward compatible.
I just moved YTMusicTransfer to another file and modify the main method argument getter.
Which still work when you call YouTube.py directly.

@lucasrangit
Copy link

@PattoMotto , @sigma67 I can try and tease out some of these changes into smaller commits if either of you don't have time. I see some useful changes and improvements.

@sigma67
Copy link
Owner

sigma67 commented May 28, 2021

For sure, the main thing that prevented me from looking at it was the size of the change and I wasn't sure if it was compatible with my own app branch

@PattoMotto
Copy link
Author

@lucasrangit Thanks :)

@sigma67 sigma67 closed this Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants