Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Otl go 1.20 #2559

Closed
wants to merge 5 commits into from
Closed

Otl go 1.20 #2559

wants to merge 5 commits into from

Conversation

jvoravong
Copy link
Contributor

@jvoravong jvoravong marked this pull request as ready for review February 14, 2023 17:56
@jvoravong jvoravong requested review from a team as code owners February 14, 2023 17:56
@jeffreyc-splunk
Copy link
Contributor

Need to also update the versions for CI. See #2493.

Makefile.Common Outdated Show resolved Hide resolved
@jvoravong
Copy link
Contributor Author

jvoravong commented Feb 14, 2023

@rmfitzpatrick,
It seems go 1.20 has major memory leak issues with running with the go 1.19 golangci-lint module.
golangci/golangci-lint#3535

Trying to run make commands that execute “go mod tidy -compat=1.19” and golangci-lint causes memory usage to go up +50gb on my local machine and CI/CD steps to fail.

This seems like a blocker for upgrading at the moment. Will likely close this pull request later unless advised otherwise.

@atoulme
Copy link
Contributor

atoulme commented Feb 15, 2023

Do you see this happen on CI too? I see some development around this issue here: golangci/golangci-lint#3414

Specifically this comment:

I guess you are installing golangci-lint with brew, brew uses go1.19 instead of go1.20.
golangci/golangci-lint#3565 (comment)

So you have to use either our binaries or our Docker image or build/install golangci-lint with go1.20.

golangci-lint requires to be built with go1.20, without that golangci-lint cannot work with go1.20.

Note the latest version of golangci-lint is v1.51.1.

@jvoravong
Copy link
Contributor Author

Yeah it breaks CI/CD by causing the pipeline to timeout or get killed.
https://github.com/signalfx/splunk-otel-collector/actions/runs/4178046114/jobs/7236846056

@jvoravong
Copy link
Contributor Author

Closing this PR for now. Will add Go 1.20 support in the future.

@jvoravong jvoravong closed this Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants