Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update regex filter + unit tests #852

Merged
merged 4 commits into from
Oct 3, 2024
Merged

Update regex filter + unit tests #852

merged 4 commits into from
Oct 3, 2024

Conversation

shumone
Copy link
Contributor

@shumone shumone commented Sep 30, 2024

Description

This PR adds unit tests for testing the new regex filter for url stack trace parsing in the error instrumentation, which will be used for retrieving source map ids from minified files.

Type of change

Delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Chore or internal change (changes not visible to the consumers of the package)
  • Documentation update

How has this been tested?

Delete options that are not relevant.

  • Manual testing
  • Added unit tests

@shumone shumone requested review from a team as code owners September 30, 2024 23:03
Copy link

github-actions bot commented Sep 30, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@shumone shumone changed the title Regex filter Update regex filter + unit tests Sep 30, 2024
@shumone
Copy link
Contributor Author

shumone commented Oct 1, 2024

I have read the CLA Document and I hereby sign the CLA

@t2t2
Copy link
Contributor

t2t2 commented Oct 1, 2024

needs a rebase now that #838 has been merged (mainly due to squash during merge)

srv-gh-o11y-gdi-cla added a commit to splunk/cla-agreement that referenced this pull request Oct 1, 2024
@shumone
Copy link
Contributor Author

shumone commented Oct 1, 2024

There is 1 CLA committer that was added automatically accidentally (I think one of my earlier commits had a different configured user name than my github username, and its matching with him now). How can I remove this committer? @t2t2

@t2t2
Copy link
Contributor

t2t2 commented Oct 2, 2024

Since github does account matching by e-mail, add alan.shum@appdynamics.com (which is set as the author in 4822c48 and 7276f4f commits) to the list of emails your account matches in github, then those commits get correctly linked to your account and I can probably re-run CLA Assistant action to fix it

@t2t2
Copy link
Contributor

t2t2 commented Oct 2, 2024

Merging is blocked
The base branch requires all commits to be signed. Learn more about signing commits.

4822c48 being unverified is blocking merging

The email in this signature doesn’t match the committer email.
GPG key ID: 6FE45C1F8F2EF301

@t2t2 t2t2 merged commit d47db98 into signalfx:main Oct 3, 2024
5 of 6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants