Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Falcon example to use version 3 #134

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

konfortes
Copy link

Falcon 2 is rarely used, there's version 4 out there. Change the example to use version 3 of falcon which deprecates the API class in favor of App. The falcon instrumentation package in version 3 only able to inject the middleware when the App class is used.

Falcon 2 is rarely used, there's version 4 out there. Change the example to use version 3 of falcon which deprecates the API class in favor of App. The falcon instrumentation package in version 3 only able to inject the middleware when the App class is used.
@konfortes konfortes mentioned this pull request Nov 10, 2022


app = falcon.API()
app = falcon.App()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change plus version update should be enough. Any reason to remove tracing or change the quotation marks?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,
I'll change back to single quotes 👍🏻

I find it very confusing that Falcon is the only tracing example with a manual trace.
This repo tends to supply examples of how to instrument different frameworks. Using the SDK to start a trace manually has nothing to do with this framework or the other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants