Don't use k8schain, statically link cloud cred helpers in cosign #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Hall <jasonhall@redhat.com>
Signed-off-by: Jason Hall <jasonhall@redhat.com>
mattmoor
approved these changes
Jan 20, 2022
7 tasks
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
…store#1279) * Don't use k8schain, statically link cloud cred helpers in cosign Signed-off-by: Jason Hall <jasonhall@redhat.com> * Remove unnecessary nil check which was confusing linter Signed-off-by: Jason Hall <jasonhall@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cosignbinary size does not change (~88MB) -- it actually get slightly smaller by about 12 KB.k8schaindepends on an unmaintained fork of kubernetes code in order to pick up cred helper logic for GCR/ECR/ACR. Instead, we can statically link the code that powers ECR/ACR cred helpers, and include ggcr's equivalent keychain.This doesn't remove the k8schain dependency from the cosigned webhook validator, but a future change could fix that after/using google/go-containerregistry#1234
Release Note
cc @mattmoor