Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported k8s versions #1430

Merged
merged 6 commits into from
May 23, 2024
Merged

Conversation

codysoyland
Copy link
Member

chainguard-dev/actions/setup-kind no longer supports v1.23 and v1.24, so I'm removing them and adding the new versions.

Signed-off-by: Cody Soyland codysoyland@github.com

Summary

Release Note

Documentation

chainguard-dev/actions/setup-kind no longer supports v1.23 and v1.24, so I'm removing them and adding the new versions.

Signed-off-by: Cody Soyland <codysoyland@github.com>
hectorj2f
hectorj2f previously approved these changes May 15, 2024
@hectorj2f
Copy link
Collaborator

You might want to upgrade scaffolding version and probably knative accordingly in the .github actions, e.g. SCAFFOLDING_RELEASE_VERSION.

@hectorj2f
Copy link
Collaborator

@codysoyland there is a draft PR from @cpanato bumping the version here: #1063. Perhaps you can cherry pick his changes and hand hold that PR towards the finish line.

@cpanato
Copy link
Member

cpanato commented May 16, 2024

i was dong that in my local :) but @codysoyland as you have this pr in place lets go with this one, let me know if you need any help

Signed-off-by: Cody Soyland <codysoyland@github.com>
@codysoyland
Copy link
Member Author

Gotcha, I didn't realize @cpanato was already working on that! I just bumped scaffolding so hopefully that helps!

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.19%. Comparing base (50ef092) to head (cc6de31).
Report is 63 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1430       +/-   ##
===========================================
- Coverage   52.92%   42.19%   -10.74%     
===========================================
  Files          44      119       +75     
  Lines        3979     7124     +3145     
===========================================
+ Hits         2106     3006      +900     
- Misses       1651     3766     +2115     
- Partials      222      352      +130     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Cody Soyland <codysoyland@github.com>
Signed-off-by: Cody Soyland <codysoyland@github.com>
@@ -53,7 +55,7 @@ jobs:

env:
KO_DOCKER_REPO: "registry.local:5000/policy-controller"
SCAFFOLDING_RELEASE_VERSION: "v0.6.5"
SCAFFOLDING_RELEASE_VERSION: "v0.6.17"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cut a new release for scaffolding: https://github.com/sigstore/scaffolding/releases/tag/v0.7.1

but that we will need to drop 1.25/1.26 from the matrix

Signed-off-by: Cody Soyland <codysoyland@github.com>
Signed-off-by: Cody Soyland <codysoyland@github.com>
@codysoyland
Copy link
Member Author

@cpanato @hectorj2f I think this is ready to go, but the required checks need to be updated in the settings because I have removed some older supported versions (per Carlos's last comment). I don't have access to that.

Also, I updated the supported versions table in the README, but it seems it hasn't been updated in several releases, so I'm not sure where the compatibility with older versions may have been broken. Please have a look if you can. Thanks!

@cpanato
Copy link
Member

cpanato commented May 21, 2024

@cpanato @hectorj2f I think this is ready to go, but the required checks need to be updated in the settings because I have removed some older supported versions (per Carlos's last comment). I don't have access to that.

Also, I updated the supported versions table in the README, but it seems it hasn't been updated in several releases, so I'm not sure where the compatibility with older versions may have been broken. Please have a look if you can. Thanks!

cool

thank you!
i will update the checks

@cpanato
Copy link
Member

cpanato commented May 21, 2024

we need to merge this sigstore/community#446 then it will update the checks and then we can merge this pr :)

thanks for all your work here @codysoyland

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@cpanato cpanato merged commit 861513d into sigstore:main May 23, 2024
73 of 74 checks passed
@github-actions github-actions bot added this to the v1 milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants