-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update supported k8s versions #1430
Conversation
chainguard-dev/actions/setup-kind no longer supports v1.23 and v1.24, so I'm removing them and adding the new versions. Signed-off-by: Cody Soyland <codysoyland@github.com>
d06a18b
to
713f237
Compare
You might want to upgrade scaffolding version and probably knative accordingly in the .github actions, e.g. |
@codysoyland there is a draft PR from @cpanato bumping the version here: #1063. Perhaps you can cherry pick his changes and hand hold that PR towards the finish line. |
i was dong that in my local :) but @codysoyland as you have this pr in place lets go with this one, let me know if you need any help |
Signed-off-by: Cody Soyland <codysoyland@github.com>
Gotcha, I didn't realize @cpanato was already working on that! I just bumped scaffolding so hopefully that helps! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1430 +/- ##
===========================================
- Coverage 52.92% 42.19% -10.74%
===========================================
Files 44 119 +75
Lines 3979 7124 +3145
===========================================
+ Hits 2106 3006 +900
- Misses 1651 3766 +2115
- Partials 222 352 +130 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Cody Soyland <codysoyland@github.com>
Signed-off-by: Cody Soyland <codysoyland@github.com>
@@ -53,7 +55,7 @@ jobs: | |||
|
|||
env: | |||
KO_DOCKER_REPO: "registry.local:5000/policy-controller" | |||
SCAFFOLDING_RELEASE_VERSION: "v0.6.5" | |||
SCAFFOLDING_RELEASE_VERSION: "v0.6.17" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cut a new release for scaffolding: https://github.com/sigstore/scaffolding/releases/tag/v0.7.1
but that we will need to drop 1.25/1.26 from the matrix
Signed-off-by: Cody Soyland <codysoyland@github.com>
Signed-off-by: Cody Soyland <codysoyland@github.com>
@cpanato @hectorj2f I think this is ready to go, but the required checks need to be updated in the settings because I have removed some older supported versions (per Carlos's last comment). I don't have access to that. Also, I updated the supported versions table in the README, but it seems it hasn't been updated in several releases, so I'm not sure where the compatibility with older versions may have been broken. Please have a look if you can. Thanks! |
cool thank you! |
we need to merge this sigstore/community#446 then it will update the checks and then we can merge this pr :) thanks for all your work here @codysoyland |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
chainguard-dev/actions/setup-kind no longer supports v1.23 and v1.24, so I'm removing them and adding the new versions.
Signed-off-by: Cody Soyland codysoyland@github.com
Summary
Release Note
Documentation