Skip to content

Commit

Permalink
test_sign: disable more staging tests (#997)
Browse files Browse the repository at this point in the history
* test_sign: disable more staging tests

Signed-off-by: William Woodruff <william@trailofbits.com>

* ci: add --skip-staging to interactive tests too

Not sure why we have this split.

Signed-off-by: William Woodruff <william@trailofbits.com>

* Revert "test_sign: disable more staging tests"

This reverts commit a105caa.

* conftest: another skipping strategy

Signed-off-by: William Woodruff <william@trailofbits.com>

* disable skip

Signed-off-by: William Woodruff <william@trailofbits.com>

* test: actually delete old skip stuff

Signed-off-by: William Woodruff <william@trailofbits.com>

---------

Signed-off-by: William Woodruff <william@trailofbits.com>
  • Loading branch information
woodruffw committed May 1, 2024
1 parent 8c6c45f commit 751a07e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:

- name: test (interactive)
if: (github.event_name != 'pull_request') || !github.event.pull_request.head.repo.fork
run: make test-interactive TEST_ARGS="-vv --showlocals"
run: make test-interactive TEST_ARGS="-vv --showlocals --skip-staging"

- uses: ./.github/actions/upload-coverage
# only aggregate test coverage over linux-based tests to avoid any OS-specific filesystem information stored in
Expand Down
1 change: 1 addition & 0 deletions test/unit/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,7 @@ def tuf_dirs(monkeypatch, tmp_path):

@pytest.fixture
def sign_ctx_and_ident_for_env(
pytestconfig,
env: str,
) -> tuple[type[SigningContext], type[IdentityToken]]:
if env == "staging":
Expand Down

0 comments on commit 751a07e

Please sign in to comment.